Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing testcases in example folder #749

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Jul 7, 2024

Description

  • fix: Add missing testcases for ISIS in example folder
  • fix: Add missing testcases for anta.tests.configuration.VerifyRunningConfigLines in example folder
  • doc: Update example README with missing files

Fixes #743

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@titom73 titom73 requested review from mtache and carl-baillargeon and removed request for mtache July 7, 2024 13:10
@titom73 titom73 added the documentation Improvements or additions to documentation label Jul 7, 2024
@titom73 titom73 added this to the v1.1.0 milestone Jul 7, 2024
examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jul 8, 2024

@titom73 titom73 merged commit e8e2038 into aristanetworks:main Jul 8, 2024
16 checks passed
@titom73 titom73 deleted the fix/743-add-isis-testcases branch July 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rn: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tests to examples/tests.yaml
2 participants